-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade base image to ubuntu:22.04 #9551
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9551 +/- ##
=======================================
Coverage 45.79% 45.79%
=======================================
Files 222 222
Lines 26377 26377
=======================================
Hits 12079 12079
Misses 12650 12650
Partials 1648 1648 Continue to review full report at Codecov.
|
Thanks @34fathombelow ! I really would prefer to split this up into three separate PRs and merge them in the following order:
|
@jannfis Im fine with that, but the SSH related changes would need to be merged first. Ubuntu 22.04 now uses the |
Signed-off-by: douhunt <douhunt@protonmail.com>
e900066
to
b9b48b2
Compare
@jannfis Made the changes you requested. Three separate PRs ( this PR, #9561, & #9563 ) for the image base upgrade. Just a reminder #9561 will need to be merged first. Our current Github CI is using Ubuntu 20.04 as a testing platform, that is why the e2e test are passing on this current PR. I would honestly feel much more comfortable with the runners using 22.04 even though the runners are in beta. I ran all unit and e2e tests through the dockerized toolchain using 22.04. e2e would not complete successfully till the Kex-algorithms were updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Signed-off-by: douhunt <douhunt@protonmail.com> Co-authored-by: douhunt <douhunt@protonmail.com> Co-authored-by: Michael Crenshaw <michael@crenshaw.dev> Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Cherry-picked onto 2.4. |
Signed-off-by: douhunt <douhunt@protonmail.com> Co-authored-by: douhunt <douhunt@protonmail.com> Co-authored-by: Michael Crenshaw <michael@crenshaw.dev> Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> chore: update Kex-Algorithms (argoproj#9561) * chore: update Kex-Algorithms Signed-off-by: douhunt <douhunt@protonmail.com> * sorted kex-algorithms Signed-off-by: 34FathomBelow <34fathombelow@protonmail.com> Co-authored-by: douhunt <douhunt@protonmail.com> Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> chore upgrade base image for test containers Ubuntu:22.04 (argoproj#9563) Signed-off-by: 34FathomBelow <34fathombelow@protonmail.com>
Signed-off-by: douhunt <douhunt@protonmail.com> Co-authored-by: douhunt <douhunt@protonmail.com> Co-authored-by: Michael Crenshaw <michael@crenshaw.dev> Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> chore: update Kex-Algorithms (argoproj#9561) * chore: update Kex-Algorithms Signed-off-by: douhunt <douhunt@protonmail.com> * sorted kex-algorithms Signed-off-by: 34FathomBelow <34fathombelow@protonmail.com> Co-authored-by: douhunt <douhunt@protonmail.com> Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> chore upgrade base image for test containers Ubuntu:22.04 (argoproj#9563) Signed-off-by: 34FathomBelow <34fathombelow@protonmail.com>
Signed-off-by: Justin Marquis 34fathombelow@protonmail.com
Part 2 of 3 to upgrade base image to Ubuntu:22.04
This PR upgrades base image to Ubuntu 22.04.
I do believe this will need to be cherry-picked into 2.4, the old base image will no longer recieve security updates after July 14, 2022
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: